style: Account for cousin sharing in the revalidation logic. #16670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
emilio
force-pushed
the
sharing-is-sometimes-hard
branch
from
359f9e1
to
fde41bf
Compare
bholley
reviewed
May 1, 2017
| @@ -375,10 +376,7 @@ impl Stylist { | |||
| #[inline] | |||
| fn note_for_revalidation(&mut self, selector: &Selector<SelectorImpl>) { | |||
| if needs_revalidation(selector) { | |||
| // For revalidation, we can skip everything left of the first ancestor | |||
| // combinator. | |||
| let revalidation_sel = selector.inner.slice_to_first_ancestor_combinator(); | |||
There was a problem hiding this comment.
We should probably get rid of the slice_to_first_ancestor_combinator() API while we're at it. I don't think we use it for anything else.
There was a problem hiding this comment.
Oh, I'd bet I had done that... Probably stashed it on the way, huh. Will do
|
@bors-servo delegate+ |
|
✌️ @emilio can now approve this pull request |
emilio
force-pushed
the
sharing-is-sometimes-hard
branch
from
fde41bf
to
f879140
Compare
|
@bors-servo r=bholley |
|
📌 Commit f879140 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 1, 2017
style: Account for cousin sharing in the revalidation logic. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1361013 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16670) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1361013
This change is