explicitly specify bitness for x86 cross-compilation situations #16843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite compiling for architecture X, the user may have specified a clang that defaults to architecture Y. We need to ensure that we invoke clang with the correct architecture selection. We do not use --target to do this, however, because that runs into problems with LLVM's default search paths. For the x86 case, we can simply use -m$BITNESS to select the correct architecture.
|
|
highfive
added
the
S-awaiting-review
|
@bors-servo r+ Thanks! |
|
📌 Commit e966d97 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 13, 2017
explicitly specify bitness for x86 cross-compilation situations Despite compiling for architecture X, the user may have specified a clang that defaults to architecture Y. We need to ensure that we invoke clang with the correct architecture selection. We do not use --target to do this, however, because that runs into problems with LLVM's default search paths. For the x86 case, we can simply use -m$BITNESS to select the correct architecture. This is not at all a general solution, but it does unblock compiling Stylo for 32-bit Linux on Gecko's infra. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16843) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite compiling for architecture X, the user may have specified a
clang that defaults to architecture Y. We need to ensure that we invoke
clang with the correct architecture selection. We do not use --target
to do this, however, because that runs into problems with LLVM's default
search paths. For the x86 case, we can simply use -m$BITNESS to select
the correct architecture.
This is not at all a general solution, but it does unblock compiling Stylo for 32-bit Linux on Gecko's infra.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is