Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylo: Make all attribute selectors respect case insensitivity #17247

Merged
merged 2 commits into from
Jun 9, 2017
Merged

stylo: Make all attribute selectors respect case insensitivity #17247

merged 2 commits into from
Jun 9, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jun 8, 2017 •
edited by larsbergstrom
Loading

@highfive
Copy link

highfive commented Jun 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/gecko/wrapper.rs, components/style/dom.rs, components/style/gecko/snapshot.rs
  • @KiChjang: components/script/layout_wrapper.rs
  • @fitzgen: components/script/layout_wrapper.rs
  • @emilio: components/style/gecko/generated/bindings.rs, components/style/gecko/wrapper.rs, components/style/dom.rs, components/style/gecko/snapshot.rs

@highfive
Copy link

highfive commented Jun 8, 2017

warning Warning warning

  • These commits modify style and script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 8, 2017
@Manishearth
Copy link
Member Author

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit 5b86afd has been approved by SimonSapin

@highfive highfive assigned SimonSapin and unassigned wafflespeanut Jun 8, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 8, 2017
@Manishearth
Copy link
Member Author

@bors-servo p=2

@bors-servo
Copy link
Contributor

⌛ Testing commit 5b86afd with merge a6b3bf1...

bors-servo pushed a commit that referenced this pull request Jun 9, 2017
Auto merge of #17247 - Manishearth:stylo-insensitive-selectors, r=Sim…
a6b3bf1 
…onSapin

stylo: Make all attribute selectors respect case insensitivity

r=simonsapin https://bugzilla.mozilla.org/show_bug.cgi?id=1364162

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17247)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing a6b3bf1 to master...

@bors-servo bors-servo merged commit 5b86afd into servo:master Jun 9, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 9, 2017
@Manishearth Manishearth deleted the stylo-insensitive-selectors branch May 7, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Manishearth @highfive @bors-servo @SimonSapin @wafflespeanut