Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dropping rule nodes after rule tree teardown #17585

Merged
merged 4 commits into from
Jul 1, 2017
Merged

Allow dropping rule nodes after rule tree teardown #17585

merged 4 commits into from
Jul 1, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented Jul 1, 2017 •
edited by larsbergstrom
Loading

@bholley
Stop GCing before dropping the root rule node.
31b1233 
We already gc before dropping the RuleTree.
@bholley
Hook into the Gecko leak checking machinery.
654661d 
Since we're going to stop asserting that all RuleNodes have been
destroyed by the time the RuleTree is destroyed, we want reliable leak
checking.
@bholley
Use a different sentinel value to lock the free list.
67cd974 
We're going to use null to indicate that the final GC has already
occurred.
@bholley
Allow StrongRuleNode drops after RuleTree destruction.
6ade9c1
@highfive
Copy link

highfive commented Jul 1, 2017

Heads up! This PR modifies the following files:

  • @emilio: components/style/stylist.rs, components/style/rule_tree/mod.rs

@highfive
Copy link

highfive commented Jul 1, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 1, 2017
@bholley
Copy link
Contributor Author

bholley commented Jul 1, 2017

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 6ade9c1 has been approved by emilio

@highfive highfive assigned emilio and unassigned KiChjang Jul 1, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 1, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 6ade9c1 with merge 78f05bf...

bors-servo pushed a commit that referenced this pull request Jul 1, 2017
Auto merge of #17585 - bholley:rule_tree_teardown, r=emilio
78f05bf 
Allow dropping rule nodes after rule tree teardown

https://bugzilla.mozilla.org/show_bug.cgi?id=1377010
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 78f05bf to master...

@bors-servo bors-servo merged commit 6ade9c1 into servo:master Jul 1, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bholley @highfive @bors-servo @emilio @KiChjang