style: Fix starts_with_ignore_ascii_case. #17640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, fix a panic when the input is not ASCII and we happen to index in something that is not a char boundary. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379380
|
Heads up! This PR modifies the following files:
|
emilio
commented
Jul 8, 2017
components/style/str.rs
Outdated
| @@ -149,5 +149,5 @@ pub fn str_join<I, T>(strs: I, join: &str) -> String | |||
| /// Returns true if a given string has a given prefix with case-insensitive match. | |||
| pub fn starts_with_ignore_ascii_case(string: &str, prefix: &str) -> bool { | |||
| string.len() > prefix.len() && | |||
There was a problem hiding this comment.
I guess this should technically be >= (though it doesn't matter due to the callsites). I'll fix too.
|
r? @nox or @SimonSapin (or anyone else really) |
|
@bors-servo r=stshine |
|
📌 Commit 9e00efc has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jul 8, 2017
style: Fix starts_with_ignore_ascii_case. In particular, fix a panic when the input is not ASCII and we happen to index in something that is not a char boundary. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379380 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17640) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, fix a panic when the input is not ASCII and we happen to index in
something that is not a char boundary.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1379380
This change is