Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit lifetime arguments on a method call. #17785

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jul 19, 2017

This causes a warning it today’s Nightly: rust-lang/rust#42868

… which makes the build fail because we use #![deny(warnings)]. This warning is planned to become a hard error in a future Rust version.


This change is Reviewable

This causes a warning it today’s Nightly:
rust-lang/rust#42868

… which makes the build fail because we use `#![deny(warnings)]`.
This warning is planned to become a hard error in a future Rust version.
@nox
Copy link
Contributor

nox commented Jul 19, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2f46a0d has been approved by nox

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 19, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 2f46a0d with merge 9597fec...

bors-servo pushed a commit that referenced this pull request Jul 19, 2017
Remove explicit lifetime arguments on a method call.

This causes a warning it today’s Nightly: rust-lang/rust#42868

… which makes the build fail because we use `#![deny(warnings)]`. This warning is planned to become a hard error in a future Rust version.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17785)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: nox
Pushing 9597fec to master...

@bors-servo bors-servo merged commit 2f46a0d into master Jul 19, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 19, 2017
@SimonSapin SimonSapin deleted the future-break branch July 21, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants