Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Avoid exponential blowup when processing invalidations of the same kind. #17888

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Jul 27, 2017

Bug: 1383981
Reviewed-by: heycam
MozReview-Commit-ID: HZ97UwvblkQ


This change is Reviewable

…same kind.

Bug: 1383981
Reviewed-by: heycam
MozReview-Commit-ID: HZ97UwvblkQ
@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/invalidation/element/invalidator.rs
  • @canaltinova: components/style/invalidation/element/invalidator.rs

@highfive
Copy link

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 27, 2017
@emilio
Copy link
Member Author

emilio commented Jul 27, 2017

@bors-servo r=heycam p=1

@bors-servo
Copy link
Contributor

📌 Commit 4c391ca has been approved by heycam

@highfive highfive assigned heycam and unassigned glennw Jul 27, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 27, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 4c391ca with merge a56d3a5...

bors-servo pushed a commit that referenced this pull request Jul 27, 2017
style: Avoid exponential blowup when processing invalidations of the same kind.

Bug: 1383981
Reviewed-by: heycam
MozReview-Commit-ID: HZ97UwvblkQ
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: heycam
Pushing a56d3a5 to master...

@bors-servo bors-servo merged commit 4c391ca into servo:master Jul 27, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants