Clean up and simplify layout traversal code #18004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
|
r? @pcwalton |
pcwalton
reviewed
Aug 8, 2017
components/layout/traversal.rs
Outdated
| } | ||
|
|
||
| flow.build_display_list(&mut self.state); | ||
| flow::mut_base(flow).restyle_damage.remove(REPOSITION|REPAINT); |
There was a problem hiding this comment.
nit: space before and after | here. r=me with that.
jdm
added
S-needs-code-changes
mbrubeck
force-pushed
the
layout-cleanup
branch
from
6655cbc
to
4c39cf3
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=pcwalton |
|
📌 Commit 4c39cf3 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 8, 2017
Clean up and simplify layout traversal code Various refactorings of the code for traversing flow trees, including: * Add a generic inorder traversal method * Remove unused `traverse_postorder_absolute_flows` method * Combine `compute_absolute_position` and `build_display_list` into a single traversal * Move all generic traversal code into the `layout::traversal` module And some changes to add documentation and more-accurate names: * Fix spelling of `bottom_up_flow` * Rename `compute_absolute_position` to `compute_stacking_relative_position` * Change the mis-named `traverse_flow_tree_preorder` to `reflow` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are refactoring only <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18004) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt4 |
highfive
added
S-tests-failed
|
mbrubeck
force-pushed
the
layout-cleanup
branch
from
4c39cf3
to
75bf708
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=pcwalton The test failures were caused by the commit that combined |
|
📌 Commit 75bf708 has been approved by |
highfive
added
S-awaiting-merge
mbrubeck
force-pushed
the
layout-cleanup
branch
from
75bf708
to
ca300d6
Compare
highfive
added
S-awaiting-review
|
@bors-servo r=pcwalton Restored some more cleanup from the reverted commit. |
|
📌 Commit ca300d6 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 8, 2017
Clean up and simplify layout traversal code Various refactorings of the code for traversing flow trees, including: * Add a generic inorder traversal method * Remove unused `traverse_postorder_absolute_flows` method * Combine `compute_absolute_position` and `build_display_list` into a single traversal * Move all generic traversal code into the `layout::traversal` module And some changes to add documentation and more-accurate names: * Fix spelling of `bottom_up_flow` * Rename `compute_absolute_position` to `compute_stacking_relative_position` * Change the mis-named `traverse_flow_tree_preorder` to `reflow` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because they are refactoring only <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18004) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various refactorings of the code for traversing flow trees, including:
traverse_postorder_absolute_flowsmethodcompute_absolute_positionandbuild_display_listinto a single traversallayout::traversalmoduleAnd some changes to add documentation and more-accurate names:
bottom_up_flowcompute_absolute_positiontocompute_stacking_relative_positiontraverse_flow_tree_preordertoreflow./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is