Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname #18350

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Sep 1, 2017

They don't have the flag in Gecko.

Though I wonder if we could unship them from non-UA sheets.

Bug: 1396048
Reviewed-by: bholley
MozReview-Commit-ID: LGzGDjCZpJC


This change is Reviewable

@highfive
Copy link

highfive commented Sep 1, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/non_ts_pseudo_class_list.rs
  • @canaltinova: components/style/gecko/non_ts_pseudo_class_list.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 1, 2017
@highfive
Copy link

highfive commented Sep 1, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Sep 1, 2017

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

📌 Commit ed6b631 has been approved by bholley

@highfive highfive assigned bholley and unassigned glennw Sep 1, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 1, 2017
…localname.

They don't have the flag in Gecko.

Though I wonder if we could unship them from non-UA sheets.

Bug: 1396048
Reviewed-by: bholley
MozReview-Commit-ID: LGzGDjCZpJC
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 1, 2017
@emilio
Copy link
Member Author

emilio commented Sep 1, 2017

@bors-servo r=bholley,manishearth

@bors-servo
Copy link
Contributor

📌 Commit 480314a has been approved by bholley,manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 1, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 480314a with merge e0e0953...

bors-servo pushed a commit that referenced this pull request Sep 2, 2017
…ishearth

stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname

They don't have the flag in Gecko.

Though I wonder if we could unship them from non-UA sheets.

Bug: 1396048
Reviewed-by: bholley
MozReview-Commit-ID: LGzGDjCZpJC

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18350)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley,manishearth
Pushing e0e0953 to master...

@bors-servo bors-servo merged commit 480314a into servo:master Sep 2, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants