Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Overflow fixes #18399

Merged
merged 2 commits into from
Sep 6, 2017
Merged

stylo: Overflow fixes #18399

merged 2 commits into from
Sep 6, 2017

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Sep 6, 2017

@highfive
Copy link

highfive commented Sep 6, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/length.rs, components/style/properties/gecko.mako.rs, components/style/values/animated/mod.rs
  • @canaltinova: components/style/values/specified/length.rs, components/style/properties/gecko.mako.rs, components/style/values/animated/mod.rs
  • @emilio: components/style/values/specified/length.rs, components/style/properties/gecko.mako.rs, components/style/values/animated/mod.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 6, 2017
@highfive
Copy link

highfive commented Sep 6, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@Manishearth
Copy link
Member Author

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit e4de8d1 has been approved by emilio

@highfive highfive assigned emilio and unassigned metajack Sep 6, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 6, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e4de8d1 with merge 812cac7...

bors-servo pushed a commit that referenced this pull request Sep 6, 2017
stylo: Overflow fixes

r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1397363 , https://bugzilla.mozilla.org/show_bug.cgi?id=1397439

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18399)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Sep 6, 2017
@Manishearth
Copy link
Member Author

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, linux-rel-wpt, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 812cac7 to master...

@bors-servo bors-servo merged commit e4de8d1 into servo:master Sep 6, 2017
heycam added a commit to heycam/servo that referenced this pull request Sep 7, 2017
bors-servo pushed a commit that referenced this pull request Sep 7, 2017
style: Backout #18399 for assertion failures.

Manual backout of #18399 corresponding to https://hg.mozilla.org/integration/autoland/raw-rev/ab26002b1029 which didn't take for some reason.
moz-servo-sync pushed a commit to moz-servo-sync/servo that referenced this pull request Sep 7, 2017
@Manishearth Manishearth deleted the stylo-fuzzfix branch July 11, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants