Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another couple of low-key media improvements 👶👣 #18804

Merged
merged 3 commits into from
Oct 10, 2017
Merged

Another couple of low-key media improvements 👶👣 #18804

merged 3 commits into from
Oct 10, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Oct 10, 2017 •
edited by Manishearth
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs
  • @KiChjang: components/script/dom/webidls/HTMLMediaElement.webidl, components/script/dom/htmlmediaelement.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 10, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member

emilio commented Oct 10, 2017

@bors-servo r+

@highfive highfive assigned emilio and unassigned KiChjang Oct 10, 2017
@bors-servo
Copy link
Contributor

📌 Commit e3fb99d has been approved by emilio

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 10, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit e3fb99d with merge 826352a...

bors-servo pushed a commit that referenced this pull request Oct 10, 2017
Auto merge of #18804 - servo:media, r=emilio
826352a 
Another couple of low-key media improvements 👶👣

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18804)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 826352a to master...

@bors-servo bors-servo merged commit e3fb99d into master Oct 10, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 10, 2017
@SimonSapin SimonSapin deleted the media branch October 13, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @emilio @bors-servo @KiChjang