Print the full path for errors occurring in the servo crate #19017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
highfive
added
the
S-awaiting-review
|
@tigercosmos: 🔑 Insufficient privileges: and not in try users |
1 similar comment
|
@tigercosmos: 🔑 Insufficient privileges: and not in try users |
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 25, 2017
Print the full path for errors occurring in the servo crate <!-- Please describe your changes on the following line: --> `Cargo` will print the path where it runs. Origin python script `cd` into the crate folder, so the root path is set in the crate. Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`. Origin path in error message: ``` error: expected one of `!` or `::`, found `#` --> lib.rs:24:1 ``` Now it would be: ``` error: expected one of `!` or `::`, found `use` --> ports/geckolib/glue.rs:11:1 ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9895 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-unit |
|
I don't know why it failed with: |
|
You should be able to reproduce it with |
|
I have tested cef in Ubuntu, and it can work. |
|
I am wondering where the path in error log comes from. The code I changed does not find this path. |
|
This is very peculiar. The linux cef build did pass, and all of the cross-compiles failed: arm64: |
|
Oh, I think I see the problem - the --manifest-path arguments are being added too late. On macOS for CEF, for example, we specifically append |
|
I see. It should be placed before |
|
Can someone let it try. thanks :) |
|
@bors-servo: try |
bors-servo
pushed a commit
that referenced
this pull request
Oct 26, 2017
Print the full path for errors occurring in the servo crate <!-- Please describe your changes on the following line: --> `Cargo` will print the path where it runs. Origin python script `cd` into the crate folder, so the root path is set in the crate. Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`. Origin path in error message: ``` error: expected one of `!` or `::`, found `#` --> lib.rs:24:1 ``` Now it would be: ``` error: expected one of `!` or `::`, found `use` --> ports/geckolib/glue.rs:11:1 ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9895 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017) <!-- Reviewable:end -->
|
💔 Test failed - android |
|
Need to figure out why: tigercosmos@ubuntu:~/Desktop/servo$ ./mach build --dev --android
Compiling blurdroid v0.1.4
Compiling servo v0.0.1 (file:///home/tigercosmos/Desktop/servo/ports/servo)
error: failed to run custom build command for `blurdroid v0.1.4`
process didn't exit successfully: `/home/tigercosmos/Desktop/servo/target/debug/build/blurdroid-9327ceaf311bdce9/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /checkout/src/libcore/result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.
warning: build failed, waiting for other jobs to finish...
error: failed to run custom build command for `servo v0.0.1 (file:///home/tigercosmos/Desktop/servo/ports/servo)`
process didn't exit successfully: `/home/tigercosmos/Desktop/servo/target/debug/build/servo-2f9813cfb370a209/build-script-build` (exit code: 101)
--- stdout
toolchain path is: ~/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "No such file or directory" } }', /checkout/src/libcore/result.rs:906:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.
Build FAILED in 0:00:02 |
|
I suspect this line: https://github.com/szeged/blurdroid/blob/559f03d19ead80a63232f993eaf99273b8278055/build.rs#L71 let java_files = fs::read_dir("src/java/hu/uszeged/bluetooth").unwrap().map(|p| p.unwrap().path()).collect::<Vec<_>>();… needs to use an absolute path instead of |
|
Seems we could only PR to upstream..? |
|
Yes. |
|
Yes, |
|
If you push a new commit to your branch, homu automatically cancels its previous try run, so we'll have to @bors-servo try again. |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2017
Print the full path for errors occurring in the servo crate <!-- Please describe your changes on the following line: --> `Cargo` will print the path where it runs. Origin python script `cd` into the crate folder, so the root path is set in the crate. Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`. Origin path in error message: ``` error: expected one of `!` or `::`, found `#` --> lib.rs:24:1 ``` Now it would be: ``` error: expected one of `!` or `::`, found `use` --> ports/geckolib/glue.rs:11:1 ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9895 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt4 |
|
Something wrong with git. Shall we try again? |
|
@bors-servo try |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2017
Print the full path for errors occurring in the servo crate <!-- Please describe your changes on the following line: --> `Cargo` will print the path where it runs. Origin python script `cd` into the crate folder, so the root path is set in the crate. Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`. Origin path in error message: ``` error: expected one of `!` or `::`, found `#` --> lib.rs:24:1 ``` Now it would be: ``` error: expected one of `!` or `::`, found `use` --> ports/geckolib/glue.rs:11:1 ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9895 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-css |
|
I thought this PR would not make CSS test failed? |
|
That's a known intermittent failure; it's not caused by this change. |
|
@jdm Shall we still try again? |
|
According to http://build.servo.org/grid that was the only failure! |
|
@bors-servo r+ |
|
📌 Commit a0ae816 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Nov 3, 2017
Print the full path for errors occurring in the servo crate <!-- Please describe your changes on the following line: --> `Cargo` will print the path where it runs. Origin python script `cd` into the crate folder, so the root path is set in the crate. Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`. Origin path in error message: ``` error: expected one of `!` or `::`, found `#` --> lib.rs:24:1 ``` Now it would be: ``` error: expected one of `!` or `::`, found `use` --> ports/geckolib/glue.rs:11:1 ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9895 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
|
Finally. Thanks everyone! @jdm @SimonSapin @KiChjang :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargowill print the path where it runs.Origin python script
cdinto the crate folder, so the root path is set in the crate.Now I use
--manifest-path PATHtocargo build, so the root path is atservo.Origin path in error message:
Now it would be:
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is