Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: respect allow_quirks for boxed properties. #19136

Merged
merged 1 commit into from Nov 7, 2017
Merged

style: respect allow_quirks for boxed properties. #19136

merged 1 commit into from Nov 7, 2017

Conversation

emilio
Copy link
Member

@emilio emilio commented Nov 7, 2017 •
edited by SimonSapin

This will unblock #19119

This change is Reviewable

@highfive
Copy link

highfive commented Nov 7, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/helpers.mako.rs
  • @canaltinova: components/style/properties/helpers.mako.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 7, 2017
@highfive
Copy link

highfive commented Nov 7, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!

@emilio
Copy link
Member Author

emilio commented Nov 7, 2017

r? @SimonSapin or @nox

@highfive highfive assigned SimonSapin and unassigned metajack Nov 7, 2017
@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7f07345 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 7, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 7f07345 with merge 254c659...

bors-servo pushed a commit that referenced this pull request Nov 7, 2017
Auto merge of #19136 - emilio:allow-quirks-box, r=SimonSapin
254c659 
style: respect allow_quirks for boxed properties.

This will unblock #19119

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19136)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 7, 2017
@jdm
Copy link
Member

jdm commented Nov 7, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: SimonSapin
Pushing 254c659 to master...

@bors-servo bors-servo merged commit 7f07345 into servo:master Nov 7, 2017
@emilio emilio mentioned this pull request Nov 7, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emilio @highfive @SimonSapin @bors-servo @jdm @metajack