style: More traversal cleanup. #19164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
|
r? @bzbarsky |
emilio
force-pushed
the
more-traversal-cleanup
branch
2 times, most recently
from
79afd0a
to
6732759
Compare
emilio
force-pushed
the
more-traversal-cleanup
branch
from
6732759
to
cd51bcb
Compare
|
@bors-servo try (Also, @nox or @SimonSapin may want to stamp it if they feel confident about it) |
bors-servo
pushed a commit
that referenced
this pull request
Nov 9, 2017
style: More traversal cleanup. This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
highfive
added
S-tests-failed
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 10, 2017
style: More traversal cleanup. This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-css2 |
emilio
force-pushed
the
more-traversal-cleanup
branch
from
7714390
to
17e0ec4
Compare
|
@bors-servo try This should be ready for review, I had to fix a Servo bug (39f6bb7). |
bors-servo
pushed a commit
that referenced
this pull request
Nov 10, 2017
style: More traversal cleanup. This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164) <!-- Reviewable:end -->
|
💔 Test failed - mac-rel-wpt4 |
emilio
added a commit
to emilio/servo
that referenced
this pull request
Nov 10, 2017
…pposed from add_child / remove_child. add_child / remove_child aren't called when a node character data changed. The only test that tests this is now wallpapered, but won't be after servo#19164. Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
emilio
added a commit
to emilio/servo
that referenced
this pull request
Nov 10, 2017
…ad of add_child / remove_child. add_child / remove_child aren't called when a node character data changed. This is important for finer grained invalidation. The only test that tests this is now wallpapered, but won't be after servo#19164.
emilio
force-pushed
the
more-traversal-cleanup
branch
from
17e0ec4
to
9d8e92a
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Nov 10, 2017
style: More traversal cleanup. This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
jdm
previously requested changes
Nov 10, 2017
components/script/dom/node.rs
Outdated
| // rooting? I'm pretty sure this cannot GC! | ||
| let mut current = Some(DomRoot::from_ref(self)); | ||
|
|
||
| while let Some(node) = current.take() { |
There was a problem hiding this comment.
There's no good answer for the rooting question, unfortunately. As for this code, let's use:
for node in self.ancestors() {
if node.get_flag(...) {
return;
}
node.set_flag(...);
}There was a problem hiding this comment.
I changed it to inclusive_ancestors, which is what it is intended to do.
jdm
added
S-needs-code-changes
…ramed. We only need to do this when display changes from none to non-none, so handle it explicitly when computing the cascade requirement. This patch also removes a few conditions that are redundant because they're handled also by the cascade requirement check, like the initial styling.
emilio
force-pushed
the
more-traversal-cleanup
branch
from
9d8e92a
to
3a5d70f
Compare
|
@bors-servo r+ |
|
📌 Commit 3a5d70f has been approved by |
highfive
added
S-awaiting-merge
|
@bors-servo p=1 |
bors-servo
pushed a commit
that referenced
this pull request
Nov 15, 2017
style: More traversal cleanup. This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164) <!-- Reviewable:end -->
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way.
This change is