Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background-image with linear-gradient not shown in medium blogpost #19810

Open
CYBAI opened this issue Jan 18, 2018 · 8 comments
Open

background-image with linear-gradient not shown in medium blogpost #19810

CYBAI opened this issue Jan 18, 2018 · 8 comments

Comments

@CYBAI
Copy link
Member

CYBAI commented Jan 18, 2018

URL: https://slack.engineering/f56a5995e8f1

The first word, webpack, in the blog post also has this issue but there're more anchors with text-decoration: underline in the Further reading section; thus, I screenshot the section.

In correct way, we should see the underline below the anchors which have the CSS of text-decoration.

In Firefox Nightly:
default

In Servo (built with aee0d69):
default

Tested in macOS 10.12.6

@CYBAI
Copy link
Member Author

CYBAI commented Jan 18, 2018

Here's the simplified test case and I'm going to change the title due to not issue of text-decoration.

<html>
  <style>
    a {
      text-decoration: none;
      background-image: linear-gradient(to bottom,rgba(0,0,0,.68) 50%,rgba(0,0,0,0) 50%);
      background-repeat: repeat-x;
      background-size: 2px .1em;
      background-position: 0 1.07em;
  }
  </style>
  <a href="https://webpack.js.org/">webpack</a> is a brilliant tool for bundling frontend assets.
</html>

image

@CYBAI CYBAI changed the title Underline of text-decoration: underline not shown in medium blogpost background-image with linear-gradient not shown in medium blogpost Jan 18, 2018
@emilio
Copy link
Member

emilio commented Jan 18, 2018

Thanks a lot for the test-case @CYBAI!

cc @pyfisch, this is the kind of stuff you've looked into before :)

@emilio
Copy link
Member

emilio commented Jan 18, 2018

(That being said, that's a gross way of drawing an underline :P)

@CYBAI
Copy link
Member Author

CYBAI commented Jan 18, 2018

(Haha, before inspecting it, I won't notice it's an underline in this way :P)

@jdm
Copy link
Member

jdm commented Jan 18, 2018

Yeah, this reminds me a lot of #19626.

@pyfisch
Copy link
Contributor

pyfisch commented Jan 18, 2018

(That being said, that's a gross way of drawing an underline :P)

They are kinda proud of it at Medium. 😛

Unfortunately I can not reproduce it at the moment. Attached is the rendering as I am seeing it with an up-to-date master. (Medium itself does work too) I will try a nightly build if a new one is released.

issue19810

@pyfisch
Copy link
Contributor

pyfisch commented Jan 25, 2018

medium

I still see the underlines on my Ubuntu machine but the text is not correctly rendered. The article text has line-breaks at the wrong places and the heading is a different font.

jdm confirmed that the underlines are invisible on MacOS.

@jdm
Copy link
Member

jdm commented Jan 25, 2018

screen shot 2018-01-25 at 1 15 29 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants