Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include some traversal statistics in style tracing marker #20302

Merged
merged 3 commits into from
Mar 15, 2018
Merged

Include some traversal statistics in style tracing marker #20302

merged 3 commits into from
Mar 15, 2018

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Mar 15, 2018 •
edited by SimonSapin
Loading

This is the Servo side changes of bug 1444296.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @bholley: components/style/driver.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs.rs, components/style/context.rs
  • @canaltinova: components/style/driver.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs.rs, components/style/context.rs
  • @emilio: components/style/driver.rs, components/style/gecko/generated/bindings.rs, components/style/gecko/generated/atom_macro.rs, components/style/gecko/generated/structs.rs, components/style/context.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 15, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!

@upsuper upsuper changed the title Traversal stats Include some traversal statistics in style tracing marker Mar 15, 2018
@upsuper
Copy link
Contributor Author

upsuper commented Mar 15, 2018

@bors-servo r=bholley p=1

@bors-servo
Copy link
Contributor

📌 Commit 368fb57 has been approved by bholley

@highfive highfive assigned bholley and unassigned nox Mar 15, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 15, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 368fb57 with merge 8e6cfbc...

bors-servo pushed a commit that referenced this pull request Mar 15, 2018
Auto merge of #20302 - upsuper:traversal-stats, r=bholley
8e6cfbc 
Include some traversal statistics in style tracing marker

This is the Servo side changes of [bug 1444296](https://bugzilla.mozilla.org/show_bug.cgi?id=1444296).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20302)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: bholley
Pushing 8e6cfbc to master...

@bors-servo bors-servo merged commit 368fb57 into servo:master Mar 15, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 15, 2018
@upsuper upsuper deleted the traversal-stats branch March 15, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upsuper @highfive @bors-servo @nox @bholley