Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mach.bat run doesn't show output on windows #20366

Open
jdm opened this issue Mar 20, 2018 · 3 comments
Open

mach.bat run doesn't show output on windows #20366

jdm opened this issue Mar 20, 2018 · 3 comments
Labels
A-mach C-has-patch P-windows Any version of Windows capable of running Servo

Comments

@jdm
Copy link
Member

jdm commented Mar 20, 2018

The following patch makes it appear when Servo panics:

diff --git a/python/servo/post_build_commands.py b/python/servo/post_build_commands.py
index 6e8c65e..20d031b 100644
--- a/python/servo/post_build_commands.py
+++ b/python/servo/post_build_commands.py
@@ -142,8 +142,9 @@ class PostBuildCommands(CommandBase):
             args = args + params

         try:
-            check_call(args, env=env)
+            check_output(args, env=env)
         except subprocess.CalledProcessError as e:
+            print(e.output)
             print("Servo exited with return value %d" % e.returncode)
             return e.returncode
         except OSError as e:
@jdm jdm added P-windows Any version of Windows capable of running Servo A-mach C-has-patch labels Mar 20, 2018
@highfive
Copy link

cc @wafflespeanut

@tigercosmos
Copy link
Contributor

Why not open a PR?

@jdm
Copy link
Member Author

jdm commented Mar 21, 2018

It doesn't make ./mach run work when Servo does not panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mach C-has-patch P-windows Any version of Windows capable of running Servo
Projects
None yet
Development

No branches or pull requests

3 participants