Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically allocate static atoms. #20433

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Statically allocate static atoms. #20433

merged 1 commit into from
Mar 26, 2018

Conversation

nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Mar 26, 2018 •
edited by SimonSapin
Loading

This is the Servo part of bug 1411469.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Mozilla bug 1411469
  • There are tests for these changes OR
  • These changes do not require tests because tests are on the Gecko side.

r? @emilio

This change is Reviewable

@nnethercote
Copy link
Contributor Author

Nb: froydnj gave this r+ in bug 1411469.

@emilio
Copy link
Member

emilio commented Mar 26, 2018

@bors-servo delegate+

@bors-servo
Copy link
Contributor

✌️ @nnethercote can now approve this pull request

@emilio
Copy link
Member

emilio commented Mar 26, 2018

@bors-servo r=froydnj

@bors-servo
Copy link
Contributor

📌 Commit 77e3522 has been approved by froydnj

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 26, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 77e3522 with merge 1081343...

bors-servo pushed a commit that referenced this pull request Mar 26, 2018
Auto merge of #20433 - nnethercote:bug-1411469, r=froydnj
1081343 
Statically allocate static atoms.

<!-- Please describe your changes on the following line: -->

This is the Servo part of bug 1411469.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix Mozilla bug 1411469

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because tests are on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20433)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 26, 2018
@nnethercote
Copy link
Contributor Author

Is that an infrastructure failure?

@emilio
Copy link
Member

emilio commented Mar 26, 2018

Yup, those look flaky, cc @nox, do we have issues on file for the intermittents in http://build.servo.org/builders/linux-rel-css/builds/8333/steps/shell__4/logs/filtered-wpt-errorsummary.log?

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only arm32, linux-rel-css, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: froydnj
Pushing 1081343 to master...

@bors-servo bors-servo merged commit 77e3522 into servo:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @emilio @bors-servo @highfive