Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mutable version of AllBrowsingContextsIterator #21707

Open
vimpunk opened this issue Sep 13, 2018 · 0 comments
Open

Make mutable version of AllBrowsingContextsIterator #21707

vimpunk opened this issue Sep 13, 2018 · 0 comments
Labels
A-constellation Involves the constellation

Comments

@vimpunk
Copy link
Contributor

vimpunk commented Sep 13, 2018

Currently we need to iterate over all browsing contexts in a frame tree and save their IDs in a Vec. Then, we need to iterate over them and retrieve the actual BrowsingContext instances, again and do the actual procedure of setting the is_visible field and calling Pipeline::notify_visibility. Here's the code.

It'd be nice not to have to make that copy in the beginning and lookup each browsing context twice, and instead mutate the browsing contexts in place as we iterate over them with a mutable version of AllBrowsingContextsIterator, but I'm not sure if this is possible (alas, my rust-lifetime-fu is not very advanced yet).

@jdm jdm added S-awaiting-review There is new code that needs to be reviewed. A-constellation Involves the constellation and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-constellation Involves the constellation
Projects
None yet
Development

No branches or pull requests

2 participants