Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FetchResponseListener::process_response_eof FnOnce #22550

Open
vimpunk opened this issue Dec 24, 2018 · 2 comments
Open

Make FetchResponseListener::process_response_eof FnOnce #22550

vimpunk opened this issue Dec 24, 2018 · 2 comments
Labels
C-assigned There is someone working on resolving the issue

Comments

@vimpunk
Copy link
Contributor

vimpunk commented Dec 24, 2018

Specifically, in #22478 I ran into having to work around this function taking a &mut self by cloning fields out of self to be sent to another thread. It would make things much easier if we could instead move them out of self. Since this function represents the last step of processing a response, I think it would also make semantically sense to do so, and from what I've seen, it wouldn't break existing trait implementations.
@vimpunk vimpunk mentioned this issue Dec 24, 2018
Open
5 tasks
@vimpunk
Copy link
Contributor Author

vimpunk commented Dec 24, 2018

@highfive assign me

@highfive
Copy link

Hey @mandreyel! Thanks for your interest in working on this issue. It's now assigned to you!

@highfive highfive added the C-assigned There is someone working on resolving the issue label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned There is someone working on resolving the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@highfive @vimpunk