Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding a TLS flag that panics if certain APIs are used while GC is in progress #25349

Open
jdm opened this issue Dec 20, 2019 · 0 comments
Open

Consider adding a TLS flag that panics if certain APIs are used while GC is in progress #25349

jdm opened this issue Dec 20, 2019 · 0 comments
Labels
A-content/bindings The DOM bindings I-safety Some piece of code violates memory safety guarantees.

Comments

@jdm
Copy link
Member

jdm commented Dec 20, 2019

It would be nice to have a solution for #25345 that provides more consistent failures to make it easier to notice when we're writing invalid code. One possibility is to set a flag that's stored in TLS when GC begins (for example), and make APIs like these assert that the flag is false.
@jdm jdm added A-content/bindings The DOM bindings I-safety Some piece of code violates memory safety guarantees. labels Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings The DOM bindings I-safety Some piece of code violates memory safety guarantees.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdm