Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upForbid git dependencies outside of github.com/servo/ ? #25650
Comments
|
Many of these are gone now. The remaining external git dependencies are: https://github.com/gfx-rs/naga I think it would make more sense to just get these dependencies to release new versions on crates.io and use those rather than forking them in the servo org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Last week, all builds of Servo started failing because the commit we were using in one of our git dependencies had been removed: #25591
To avoid that situation, we sometimes prefer forking a git repository into the
servoorg (where we control which branches are removed or not) and using that instead as a dependency. Should we make that a policy and enforce it?./mach test-tidyalready parsesCargo.tomland looks at thesourceof each package in the dependency graph. We could make it fail if anysourceis used other crates.io or git repositories under https://github.com/servo/These are the repositories we would need to fork before doing that: