Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_malloc_size_of for DomRefCell<TextInput<...>> cites closed issue #7193 #25679

Open
pshaughn opened this issue Feb 3, 2020 · 0 comments
Labels
A-content/dom Interacting with the DOM from web content I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@pshaughn
Copy link
Member

pshaughn commented Feb 3, 2020

#[ignore_malloc_size_of = "#7193"]
textinput: DomRefCell<TextInput<ScriptToConstellationChan>>,

#[ignore_malloc_size_of = "#7193"]
textinput: DomRefCell<TextInput<ScriptToConstellationChan>>,

We actually do need an ignore_malloc_size_of either here or in TextInput, since TextInput<T> holds a T and the T here itself holds an IPCSender. There's just room for a little cleanup to remove a reference to #7193, a closed and only half-relevant issue.

@pshaughn pshaughn changed the title ignore_malloc_sizeof for DomRefCell<TextInput<...>> cites closed issue #7193 ignore_malloc_size_of for DomRefCell<TextInput<...>> cites closed issue #7193 Feb 3, 2020
@CYBAI CYBAI added the A-content/dom Interacting with the DOM from web content label Feb 4, 2020
@jdm jdm added the I-cleanup No impact; the issue is one of maintainability or tidiness. label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/dom Interacting with the DOM from web content I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Development

No branches or pull requests

3 participants