Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_malloc_size_of in NodeIterator and HTMLCollection points at closed issue #6870 #25682

Open
pshaughn opened this issue Feb 4, 2020 · 0 comments
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@pshaughn
Copy link
Member

pshaughn commented Feb 4, 2020

Since #6870 was resolved I tried taking out the ignore_malloc_size_of lines here, but we still seem to need them. I might not understand what's really happening here, but it looks like the NodeIterator one involves an Rc<NodeFilterBinding::NodeFilter>, which seems like the kind of thing 6870 was supposed to fix. The HTMLCollection one involves a Box<dyn CollectionFilter + 'static> which seems like it probably has to stay ignore_malloc_size_of since the CollectionFilter trait could be hiding anything as far as the compiler knows. The sensible thing to do in the latter case might just be to clean up the comment and leave the ignore on, but the former could point at something to fix in the macros.

@jdm jdm added the I-cleanup No impact; the issue is one of maintainability or tidiness. label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Development

No branches or pull requests

2 participants