Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe unsilence "Why are errors silenced here?" errors #25688

Open
pshaughn opened this issue Feb 4, 2020 · 1 comment
Open

Maybe unsilence "Why are errors silenced here?" errors #25688

pshaughn opened this issue Feb 4, 2020 · 1 comment
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@pshaughn
Copy link
Member

pshaughn commented Feb 4, 2020

Numerous functions in script/dom queue a task and ignore the Result. Some of these already had a comment (mostly from @nox) asking why we were ignoring it. I tried unignoring them and adding .expect to them all in #25685 and nothing bad happened in CI (the one test failure is just an intermittent reftest of the #24726 variety).

1: Should we go ahead and merge?
2: Of the errors that didn't have that comment, are there any we already know we need to silence, or would it make sense to try unsilencing all of them?

@nox
Copy link
Contributor

nox commented Feb 10, 2020

+1 on landing your PR. We shouldn't silence stuff when we don't know why we are silencing them in the first place.

@jdm jdm added the I-cleanup No impact; the issue is one of maintainability or tidiness. label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Development

No branches or pull requests

3 participants