You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Numerous functions in script/dom queue a task and ignore the Result. Some of these already had a comment (mostly from @nox) asking why we were ignoring it. I tried unignoring them and adding .expect to them all in #25685 and nothing bad happened in CI (the one test failure is just an intermittent reftest of the #24726 variety).
1: Should we go ahead and merge?
2: Of the errors that didn't have that comment, are there any we already know we need to silence, or would it make sense to try unsilencing all of them?
The text was updated successfully, but these errors were encountered:
Numerous functions in script/dom queue a task and ignore the Result. Some of these already had a comment (mostly from @nox) asking why we were ignoring it. I tried unignoring them and adding .expect to them all in #25685 and nothing bad happened in CI (the one test failure is just an intermittent reftest of the #24726 variety).
1: Should we go ahead and merge?
2: Of the errors that didn't have that comment, are there any we already know we need to silence, or would it make sense to try unsilencing all of them?
The text was updated successfully, but these errors were encountered: