Fix text decoration bug in applicable declarations cache #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make ApplicableDeclarationsCache::cache priv - Add a missing semicolon for clarity - Remove a useless `drop` call.
Even though we don't recompute non-inherited properties here, we still need to compute properties that are derived from them. Fixes servo#2498: because text-decoration is not inherited, -servo-text-decorations-in-effect was not derived correctly for cached declarations.
|
Critic review: https://critic.hoppipolla.co.uk/r/1736 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
r? @pcwalton since he added this caching code |
bors-servo
pushed a commit
that referenced
this pull request
Jun 5, 2014
Fixes #2498. Also includes a reftest, and some related code cleanup (in separate commits). Note: The fix in `properties.rs.mako` is much more readable with `git diff -w`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2498. Also includes a reftest, and some related code cleanup (in separate commits).
Note: The fix in
properties.rs.makois much more readable withgit diff -w.