Memory issue: Leaking ImageFragmentInfo

[paulrouget]

For a simple <img>, ImageFragmentInfo are cloned/new 28 times and released 26 times. Holding the image bytes in memory.

After the pipeline is destroyed, there is still 2 arcs in memory:

servo/components/layout/fragment.rs

Line 451 in e1f6dfd

Some(Arc::new(Image {

[vbkaisetsu]

layout thread unreachable - leaking layout data occurs on reloading a page that only contains <img> tag:

% uname -a
Linux koichi-ThinkPad-T470s 5.3.0-40-generic #32-Ubuntu SMP Fri Jan 31 20:24:34 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
% echo '<img src="./resources/servo-64.png">' > ./test.html
% RUST_LOG=warn ./target/debug/servo ./test.html
[2020-03-25T08:23:27Z WARN  servo::context] Making an already current context current
[2020-03-25T08:23:27Z WARN  constellation::constellation] Visibility change for closed browsing context PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }.
[2020-03-25T08:23:29Z WARN  script::timers] Resuming an already resumed timer.

After pressing Ctrl+R:

[2020-03-25T08:23:36Z WARN  script::timers] Resuming an already resumed timer.
[2020-03-25T08:23:36Z WARN  compositing::compositor] Compositor layer has an unknown pipeline (PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }).
[2020-03-25T08:23:36Z WARN  servo_media_gstreamer] Trying to exec media action on an unknown client context
[2020-03-25T08:23:36Z WARN  script::dom::node] layout thread unreachable - leaking layout data
[2020-03-25T08:23:36Z WARN  script::dom::node] layout thread unreachable - leaking layout data
[2020-03-25T08:23:36Z WARN  script::dom::node] layout thread unreachable - leaking layout data
[2020-03-25T08:23:36Z WARN  script::dom::node] layout thread unreachable - leaking layout data
[2020-03-25T08:23:36Z WARN  script::dom::node] layout thread unreachable - leaking layout data