Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement table layout in 2020 #27459

Closed
Manishearth opened this issue Jul 31, 2020 · 3 comments
Closed

Implement table layout in 2020 #27459

Manishearth opened this issue Jul 31, 2020 · 3 comments
Assignees
@Manishearth
Labels
A-layout/table A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020

Comments

@Manishearth
Copy link
Member

https://drafts.csswg.org/css-tables/

I'm planning on working on at least part of this.
@Manishearth Manishearth added A-layout/table A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020 labels Jul 31, 2020
@Manishearth Manishearth self-assigned this Jul 31, 2020
@Manishearth
Copy link
Member Author

cc @SimonSapin @pcwalton

So my rough plan is this:

@pcwalton
Copy link
Contributor

Looks good.

@Manishearth Manishearth mentioned this issue Aug 4, 2020
Closed
bors-servo added a commit that referenced this issue Aug 10, 2020
@bors-servo
Auto merge of #27488 - Manishearth:tables-2020, r=pcwalton
942ce69 
2020: Implement table map construction

Progress towards #27459

This PR does not do any table  layout whatsoever, nor does it even
construct boxes for table elements.

What this does is construct the CellMap, which makes it easy to find
which cells are occupying each slot of the table. This will be useful
when iterating over the table repeatedly during the layout algorithms.
bors-servo added a commit that referenced this issue Aug 11, 2020
@bors-servo
Auto merge of #27488 - Manishearth:tables-2020, r=pcwalton
17abe17 
2020: Implement table map construction

Progress towards #27459

This PR does not do any table  layout whatsoever, nor does it even
construct boxes for table elements.

What this does is construct the CellMap, which makes it easy to find
which cells are occupying each slot of the table. This will be useful
when iterating over the table repeatedly during the layout algorithms.
bors-servo added a commit that referenced this issue Aug 11, 2020
@bors-servo
Auto merge of #27488 - Manishearth:tables-2020, r=pcwalton
57a87f3 
2020: Implement table map construction

Progress towards #27459

This PR does not do any table  layout whatsoever, nor does it even
construct boxes for table elements.

What this does is construct the CellMap, which makes it easy to find
which cells are occupying each slot of the table. This will be useful
when iterating over the table repeatedly during the layout algorithms.
mrobinson added a commit to mrobinson/servo that referenced this issue Nov 30, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction
14c3c1a 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward servo#27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
@mrobinson mrobinson mentioned this issue Nov 30, 2023
Merged
3 tasks
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 1, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction
bf16e8c 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward servo#27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 5, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction
91ae149 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward servo#27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 5, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction
b62780a 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward servo#27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
mrobinson added a commit to mrobinson/servo that referenced this issue Dec 5, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction
5d01814 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward servo#27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
@mrobinson @Loirooriol @Manishearth
Add initial support for table box tree construction (#30799)
f0b4162 
This is the first part of constructing the box tree for table layout. No
layout is actually done and the construction of tables is now hidden
behind a flag (in order to not regress WPT).  Notably, this does not
handle anonymous table part construction, when the DOM does not reflect
a fully-formed table. That's part two.

Progress toward #27459.

Co-authored-by: Oriol Brufau <obrufau@igalia.com>
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
This was referenced Feb 3, 2024
Closed
Closed
@mrobinson
Copy link
Member

Tables are now enabled in Layout 2020 and we will gradually make them more feature complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-layout/table A-layout/2020 https://github.com/servo/servo/wiki/Layout-2020
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrobinson @pcwalton @Manishearth