Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge selectors crate with changes from gecko? #28632

Open
devongovett opened this issue Nov 26, 2021 · 4 comments
Open

Merge selectors crate with changes from gecko? #28632

devongovett opened this issue Nov 26, 2021 · 4 comments

Comments

@devongovett
Copy link

It seems the selectors crate here (and published to crates.io) has diverged from the copy in gecko. For example, cssparser was updated to 0.29. Should the one in gecko be the one that is published to crates.io? Should the changes be merged back here? Which version is the canonical one?

I'm happy to send a PR to update cssparser in the crates.io released version but would like to understand the relationship between these two versions.

@emilio
Copy link
Member

emilio commented Nov 26, 2021

The crates.io version isn't even the servo/ version, it's the servo version with the MallocSizeOf stuff removed, IIRC.

I used to keep the Servo version periodically up-to-date, though I haven't done so in a while (I probably should).

@devongovett
Copy link
Author

Ah. How does the crates.io version get updated? Is there another repo?

@cortesi
Copy link

cortesi commented Jan 17, 2022

I have a project that relies on selectors, and the lack of updates to the crates.io package is making things a bit harder than they need to be. We are also a little concerned that development momentum in servo has petered out, and that the bits we rely on might stagnate. I wonder if it's time to consider extracting selectors into a free-standing module that would be easier to move forward?

@paulrouget
Copy link
Contributor

@emilio can you summarise the porting process from Gecko's version to a publishable version? I can take care of the migration if that's not too painful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants