Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite module loading on top of spidermonkey module loader #29089

Open
jdm opened this issue Nov 21, 2022 · 1 comment
Open

Rewrite module loading on top of spidermonkey module loader #29089

jdm opened this issue Nov 21, 2022 · 1 comment
Labels
A-content/script Related to the script thread E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation.

Comments

@jdm
Copy link
Member

jdm commented Nov 21, 2022

https://bugzilla.mozilla.org/show_bug.cgi?id=1742437 introduced common machinery for loading scripts and modules in spidermonkey. We should do a similar rewrite in Servo's implementation to take advantage of this. I suspect we will end up with:

  • less complex implementation code in script_module.rs
  • more tests passing

https://searchfox.org/mozilla-central/source/js/loader/ModuleLoaderBase.h
https://searchfox.org/mozilla-central/source/dom/script/ModuleLoader.cpp
https://searchfox.org/mozilla-central/source/dom/script/ScriptLoader.cpp
@jdm jdm added E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation. A-content/script Related to the script thread labels Nov 21, 2022
@jdm
Copy link
Member Author

jdm commented Nov 21, 2022

Depends on #29079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script Related to the script thread E-very-complex Very difficult. Do not attempt without significant relevant experience and motivation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdm