Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused import: mem, in components/net/image_cache.rs #31607

Closed
Loirooriol opened this issue Mar 10, 2024 · 1 comment · Fixed by #31608
Closed

unused import: mem, in components/net/image_cache.rs #31607

Loirooriol opened this issue Mar 10, 2024 · 1 comment · Fixed by #31608
Labels
E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@Loirooriol
Copy link
Contributor

When compiling I get

warning: unused import: `mem`
 --> components/net/image_cache.rs:9:11
  |
9 | use std::{mem, thread};
  |           ^^^
  |
  = note: `#[warn(unused_imports)]` on by default

#31564 used std::mem::take(own_bytes) instead of mem::take(own_bytes). So it's a matter of either changing the consumer into mem::take(own_bytes), or removing the import of mem.

@Loirooriol Loirooriol added E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Mar 10, 2024
@servo-highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in Zulip.

If you intend to work on this issue, then add @servo-highfive: assign me to your comment, and I'll assign this to you. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-less-complex Straightforward. Recommended for a new contributor. I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants