New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy: fix warnings in components/net #31564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a couple comments below:
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
@@ -224,7 +218,7 @@ impl ImageBytes { | |||
ImageBytes::InProgress(ref mut bytes) => bytes, | |||
ImageBytes::Complete(_) => panic!("attempted modification of complete image bytes"), | |||
}; | |||
mem::replace(own_bytes, vec![]) | |||
std::mem::take(own_bytes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either mem::take
or stop importing std::mem
, but this is causing a compile warning (#31607).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, I'll fix it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed with #31608
Split from #31514, fixes some clippy warnings in
components/net
../mach build -d
does not report any errors./mach test-tidy
does not report any errors