Add a ./mach clean-snapshots command to remove old Cargo and Rust.
#4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrapping automatically downloads new Rust and Cargo snapshots as needed into versioned directories, but do not remove now-unused versions. This is the desired behavior for `git bisect` to be usable. However, this means that old version keep accumulating, taking up disk space. This adds a mach command to remove snapshots other than the ones currently being used. It is never run automatically. To be safe, the command defaults to only printing what would be removed, and only removes stuff when run with a `-f` argument.
|
Critic review: https://critic.hoppipolla.co.uk/r/3435 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
In the future we might want to have an opt in "save snapshots" key in servobuild. |
|
@Manishearth Do you mean that removing unused snapshots would be the default during bootstrap? I’m ok with that, I just went with the less disruptive change in this PR to get done what I wanted. |
|
Yep. This PR is fine, just about to r+ it :) |
bors-servo
pushed a commit
that referenced
this pull request
Dec 9, 2014
Bootstrapping automatically downloads new Rust and Cargo snapshots as needed into versioned directories, but do not remove now-unused versions. This is the desired behavior for `git bisect` to be usable. However, this means that old version keep accumulating, taking up disk space. This adds a mach command to remove snapshots other than the ones currently being used. It is never run automatically. To be safe, the command defaults to only printing what would be removed, and only removes stuff when run with a `-f` argument. r? @mbrubeck
bors-servo
pushed a commit
that referenced
this pull request
Dec 9, 2014
Bootstrapping automatically downloads new Rust and Cargo snapshots as needed into versioned directories, but do not remove now-unused versions. This is the desired behavior for `git bisect` to be usable. However, this means that old version keep accumulating, taking up disk space. This adds a mach command to remove snapshots other than the ones currently being used. It is never run automatically. To be safe, the command defaults to only printing what would be removed, and only removes stuff when run with a `-f` argument. r? @mbrubeck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrapping automatically downloads new Rust and Cargo snapshots as needed into versioned directories, but do not remove now-unused versions. This is the desired behavior for
git bisectto be usable.However, this means that old version keep accumulating, taking up disk space. This adds a mach command to remove snapshots other than the ones currently being used. It is never run automatically.
To be safe, the command defaults to only printing what would be removed, and only removes stuff when run with a
-fargument.r? @mbrubeck