Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the Runnable implementation for HTMLScriptElement #5021

Closed
Ms2ger opened this issue Feb 22, 2015 · 0 comments
Closed

Replace the Runnable implementation for HTMLScriptElement #5021

Ms2ger opened this issue Feb 22, 2015 · 0 comments
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Feb 22, 2015

Rather than implementing Runnable for Trusted<HTMLScriptElement>, it should be implement for a custom struct, say

struct EventDispatcher {
    is_error: bool,
    element: Trusted<HTMLScriptElement>
}

This will also allow removing the undocumented and unspecified error_occurred field of HTMLScriptElement.
@Ms2ger Ms2ger added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. labels Feb 22, 2015
@tetsuharuohzeki tetsuharuohzeki mentioned this issue Feb 22, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce dom::htmlscriptelement::EventDispatcher. tetsuharuohzeki/servo
1 participant
@Ms2ger