Add support for $CARGO_HOME in servobuild #5168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/4202 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
mbrubeck
added
S-needs-code-changes
| @@ -51,6 +51,10 @@ class CommandBase(object): | |||
| def __init__(self, context): | |||
| self.context = context | |||
|
|
|||
| def resolverelative(category, key): | |||
| if self.config[category][key].startswith("./"): | |||
There was a problem hiding this comment.
path.join already ignore arguments before one that is an absolute path: path.join('/foo', 'bar') == '/foo/bar', path.join('/foo', '/bar') == '/bar'. Why special-casing ./?
There was a problem hiding this comment.
We also want to handle ~.
I'll handle ~ replacement first, then do path.join.
There was a problem hiding this comment.
You want to call os.path.expanduser first.
SimonSapin
added
S-needs-squash
|
Looks good. |
bors-servo
pushed a commit
that referenced
this pull request
Mar 7, 2015
bors-servo
pushed a commit
that referenced
this pull request
Mar 7, 2015
bors-servo
pushed a commit
that referenced
this pull request
Mar 7, 2015
bors-servo
pushed a commit
that referenced
this pull request
Mar 7, 2015
bors-servo
pushed a commit
that referenced
this pull request
Mar 8, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.