Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing blur filter. #5190

Closed
wants to merge 2 commits into from
Closed

Implementing blur filter. #5190

wants to merge 2 commits into from

Conversation

Adenilson
Copy link
Contributor

No description provided.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4229

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm jdm added the S-awaiting-review There is new code that needs to be reviewed. label Mar 11, 2015
@pcwalton
Copy link
Contributor

You are also going to need to adjust the overflow regions, or else display list optimization might clip out the edges of a blurred object (for example, if a blurred object is off the screen, but the edges of the blur are slightly on the screen). See how BLUR_INFLATION_FACTOR is used for an example.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 16, 2015
@metajack
Copy link
Contributor

@Adenilson Planning on addressing these soon?

@jdm jdm added the S-awaiting-answer Someone asked a question that requires an answer. label Mar 31, 2015
@Adenilson
Copy link
Contributor Author

Yep, I was busy last week with the placeholder feature #5330 but will resume work on it.

@jdm jdm removed the S-awaiting-answer Someone asked a question that requires an answer. label Mar 31, 2015
@metajack metajack assigned pcwalton and SimonSapin and unassigned pcwalton Mar 31, 2015
@metajack
Copy link
Contributor

Assigning @SimonSapin since he did the review.

@Adenilson Adenilson closed this Apr 2, 2015
@SimonSapin
Copy link
Member

Moved to #5496.

@Adenilson Adenilson mentioned this pull request Apr 6, 2015
Merged
bors-servo pushed a commit that referenced this pull request Apr 15, 2015
Auto merge of #5546 - Adenilson:blurFilter01, r=pcwalton
1fd6a48 
See discussion on #5190 and #5496.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5546)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-needs-code-changes Changes have not yet been made that were requested by a reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Adenilson @hoppipolla-critic-bot @pcwalton @metajack @SimonSapin @jdm