Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy files in python/, fix issues brought up by tidy #6268

Merged
merged 2 commits into from Jun 3, 2015
Merged

Tidy files in python/, fix issues brought up by tidy #6268

merged 2 commits into from Jun 3, 2015

Conversation

frewsxcv
Copy link
Contributor

@frewsxcv frewsxcv commented Jun 2, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 2, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5168

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Jun 3, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit e3b71c6 has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 3, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit e3b71c6 with merge 9aa1d93...

bors-servo pushed a commit that referenced this pull request Jun 3, 2015
Auto merge of #6268 - frewsxcv:tidy-python, r=jdm
9aa1d93 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6268)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2

@bors-servo bors-servo merged commit e3b71c6 into servo:master Jun 3, 2015
frewsxcv added a commit to frewsxcv/servo that referenced this pull request Jun 3, 2015
@frewsxcv
Run tidy everything in the tree, remove directory whitelist
6c8c039 
After servo#6268 merged, I found out that everything in the tree currently
passes the tidy checker.
@frewsxcv frewsxcv mentioned this pull request Jun 3, 2015
Merged
bors-servo pushed a commit that referenced this pull request Jun 3, 2015
Auto merge of #6274 - frewsxcv:tidy-all-the-things, r=metajack
055182d 
After #6268 merged, I found out that everything in the tree currently
passes the tidy checker.

---------------

It is worth pointing out that I personally do not know if this is a feature wanted by others. Once I noticed everything was already tidy, I decided to open this PR to start the conversation (if any). I am not convinced this is really a Good Thing, so my feelings would not get hurt if this was closed immediately.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6274)
<!-- Reviewable:end -->
@frewsxcv frewsxcv deleted the tidy-python branch October 9, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frewsxcv @hoppipolla-critic-bot @jdm @bors-servo @highfive