Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mach test-ref displays warnings #7031

Closed
Yoric opened this issue Aug 6, 2015 · 2 comments
Closed

mach test-ref displays warnings #7031

Yoric opened this issue Aug 6, 2015 · 2 comments
Labels
C-assigned There is someone working on resolving the issue

Comments

@Yoric
Copy link
Contributor

Yoric commented Aug 6, 2015

As suggested by @SimonSapin, I'm working on this.

@Yoric Yoric changed the title mach test-ref shows warnings mach test-ref displays warnings Aug 6, 2015
@Yoric
Copy link
Contributor Author

Yoric commented Aug 6, 2015

I get the following warning:

../../tests/reftest.rs:46:26: 46:32 warning: use of deprecated item: superseded by split_first, #[warn(deprecated)] on by default
../../tests/reftest.rs:46     let mut parts = args.tail().split(|e| &**e == "--");
                                                   ^~~~~~

I see two solutions here, I don't know which is preferred:

  • I can keep tail and allow deprecated code;
  • or I can switch to split_first, which is unstable, and requires me to allow the feature with #![feature(slice_splits)].

I suspect that the latter is better, but I'd like confirmation.

Yoric added a commit to Yoric/servo that referenced this issue Aug 6, 2015
Yoric added a commit to Yoric/servo that referenced this issue Aug 6, 2015
@metajack
Copy link
Contributor

metajack commented Aug 6, 2015

@Yoric Yes, we prefer the latter, at least in the servo repo. In dependencies where there is some possibility to keep the crate compiling on stable Rust, we try to do it, but for Servo, we use all the unstable features.

Yoric added a commit to Yoric/servo that referenced this issue Aug 7, 2015
@frewsxcv frewsxcv added the C-assigned There is someone working on resolving the issue label Aug 12, 2015
nerith pushed a commit to nerith/servo that referenced this issue Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-assigned There is someone working on resolving the issue
Projects
None yet
Development

No branches or pull requests

3 participants