CanvasGradient#addColorStop should throw for invalid colors and offsets #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ -S-awaiting-review +S-awaiting-merge Reviewed 5 of 5 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
nox
added
S-awaiting-merge
|
📌 Commit 33ccb64 has been approved by |
highfive
added
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Aug 9, 2015
CanvasGradient#addColorStop should throw for invalid colors and offsets The new test failure is because the color stop has a value of 'currentColor' which we don't support yet. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7104) <!-- Reviewable:end -->
|
💔 Test failed - linux2 |
highfive
added
S-tests-failed
|
@bors-servo r-
|
|
@Ms2ger Oh! |
dzbarsky
force-pushed
the
add_color_stop
branch
from
33ccb64
to
f41aee1
Compare
highfive
added
S-awaiting-review
dzbarsky
force-pushed
the
add_color_stop
branch
from
f41aee1
to
7315b50
Compare
|
@bors-servo r+ |
|
📌 Commit 7315b50 has been approved by |
highfive
removed
the
S-awaiting-review
bors-servo
pushed a commit
that referenced
this pull request
Aug 11, 2015
CanvasGradient#addColorStop should throw for invalid colors and offsets The new test failure is because the color stop has a value of 'currentColor' which we don't support yet. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7104) <!-- Reviewable:end -->
highfive
added
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test failure is because the color stop has a value of 'currentColor' which we don't support yet.