Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using overflow:auto changes the stacking order #7281

Closed
paulrouget opened this issue Aug 19, 2015 · 1 comment
Closed

Using overflow:auto changes the stacking order #7281

paulrouget opened this issue Aug 19, 2015 · 1 comment
Labels
A-layout/uncategorized

Comments

@paulrouget
Copy link
Contributor 

      <style>
        div {
          width: 100px;
          height: 100px;
          position: absolute;
          top: 0;
          left: 0;
        }
      </style>

      <div style="background:red;    overflow:auto;"></div>
      <div style="background:green;  top:10px;left:10px"> </div>

With overflow:auto, the red div is on top of the green div.

screen shot 2015-08-19 at 09 28 00
@paulrouget paulrouget mentioned this issue Aug 19, 2015
Closed
92 tasks
@pcwalton
Copy link
Contributor

This is because we don't use the LAYERS_NEEDED_FOR_POSITIONED_DESCENDANTS infrastructure in enough cases. I have what I believe to be a fix ready.

pcwalton added a commit to pcwalton/servo that referenced this issue Aug 19, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
ec0b67b 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

Closes servo#7281.
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 19, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
9cdb911 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
@pcwalton pcwalton mentioned this issue Aug 19, 2015
Merged
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 21, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
eb70fdb 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 21, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
b93cfa4 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 21, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
ea22ffd 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 21, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
e41f966 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 21, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
c0d658e 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 21, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
3d940c3 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 21, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
0aa7b24 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 22, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
1dbb877 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 22, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
6031b10 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 22, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
703dfc7 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 22, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
ddf598f 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 22, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
09cd54b 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
pcwalton added a commit to pcwalton/servo that referenced this issue Aug 22, 2015
@pcwalton
layout: Centralize the logic that determines whether fragments get
ec1c90d 
layers in the fragment, so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes servo#7281.
bors-servo pushed a commit that referenced this issue Aug 22, 2015
Auto merge of #7291 - pcwalton:has-layer-flag, r=mbrubeck
7945c17 
layout: Centralize the logic that determines whether fragments get layers in the fragment.

…so that it can be activated when we're forcing
the creation of extra layers due to positioned descendants that
themselves have layers.

The newly failing tests were tests that accidentally passed due to
incorrect stacking order.

Closes #7281.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7291)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcwalton @paulrouget @frewsxcv