Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed header API instead of set_raw in set_default_accept_encoding #7971

Merged
merged 1 commit into from Oct 11, 2015
Merged

Use typed header API instead of set_raw in set_default_accept_encoding #7971

merged 1 commit into from Oct 11, 2015

Conversation

gkbrk
Copy link
Contributor

@gkbrk gkbrk commented Oct 11, 2015

Fixes #7970

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 11, 2015
@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

@nox nox self-assigned this Oct 11, 2015
@nox
Copy link
Contributor

nox commented Oct 11, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 5eeca1f has been approved by nox

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 11, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 5eeca1f with merge 7b904ef...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 11, 2015
bors-servo pushed a commit that referenced this pull request Oct 11, 2015
Auto merge of #7971 - gkbrk:fix_7970, r=nox
7b904ef 
Use typed header API instead of set_raw in set_default_accept_encoding

Fixes #7970

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7971)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 5eeca1f into servo:master Oct 11, 2015
@gkbrk gkbrk deleted the fix_7970 branch October 11, 2015 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkbrk @highfive @nox @bors-servo