Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unrooted_must_root lint to handle arguments/return types properly #8030

Merged
merged 2 commits into from Oct 15, 2015
Merged

Fix unrooted_must_root lint to handle arguments/return types properly #8030

merged 2 commits into from Oct 15, 2015

Conversation

Manishearth
Copy link
Member

r? @jdm

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2015
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@nox nox added A-content/dom Interacting with the DOM from web content I-safety Some piece of code violates memory safety guarantees. S-fails-tidy `./mach test-tidy` reported errors. labels Oct 15, 2015
@nox
Copy link
Contributor

nox commented Oct 15, 2015 

./components/plugins/utils.rs:12: use statement is not in alphabetical order
    expected: syntax::codemap::{ExpnFormat, Span}
    found: syntax::ptr::P
./components/plugins/utils.rs:13: use statement is not in alphabetical order
    expected: syntax::ptr::P
    found: syntax::codemap::{ExpnFormat, Span}

@jdm jdm removed the S-fails-tidy `./mach test-tidy` reported errors. label Oct 15, 2015
@frewsxcv
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c077a86 has been approved by frewsxcv

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit c077a86 with merge 7799358...

@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 15, 2015
bors-servo pushed a commit that referenced this pull request Oct 15, 2015
Auto merge of #8030 - Manishearth:fix-lint-fn, r=frewsxcv
7799358 
Fix unrooted_must_root lint to handle arguments/return types properly

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8030)
<!-- Reviewable:end -->
@frewsxcv frewsxcv closed this Oct 15, 2015
@frewsxcv frewsxcv reopened this Oct 15, 2015
@frewsxcv
Copy link
Contributor

Reopened because the workers were stuck

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #8020) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 15, 2015
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 15, 2015
@Manishearth
Copy link
Member Author

@bors-servo r=frewsxcv

@bors-servo
Copy link
Contributor

📌 Commit 8819f0d has been approved by frewsxcv

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Oct 15, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 8819f0d with merge 9d5f09e...

bors-servo pushed a commit that referenced this pull request Oct 15, 2015
Auto merge of #8030 - Manishearth:fix-lint-fn, r=frewsxcv
9d5f09e 
Fix unrooted_must_root lint to handle arguments/return types properly

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8030)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 8819f0d into servo:master Oct 15, 2015
@Manishearth Manishearth deleted the fix-lint-fn branch October 15, 2015 22:01
@jdm jdm mentioned this pull request Mar 29, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content I-safety Some piece of code violates memory safety guarantees. S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Manishearth @highfive @nox @frewsxcv @bors-servo @jdm