Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused import warning in headless builds #8317

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Fix unused import warning in headless builds #8317

merged 1 commit into from
Nov 4, 2015

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Nov 3, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 3, 2015
@tetsuharuohzeki
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 112f31b has been approved by saneyuki

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 3, 2015
@eefriedman
Copy link
Contributor

@bors-servo r-

./ports/glutin/window.rs:210: use statement is not in alphabetical order
    expected: glutin::TouchPhase
    found: script_traits::{TouchEventType, TouchId}

./ports/glutin/window.rs:211: use statement is not in alphabetical order
    expected: script_traits::{TouchEventType, TouchId}
    found: glutin::TouchPhase

@eefriedman eefriedman added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 3, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 3, 2015
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Nov 3, 2015

@bors-servo r=saneyuki

@bors-servo
Copy link
Contributor

📌 Commit 58a5369 has been approved by saneyuki

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 3, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 58a5369 with merge 488459f...

bors-servo pushed a commit that referenced this pull request Nov 4, 2015
Auto merge of #8317 - mbrubeck:glutin-warning, r=saneyuki
488459f 
Fix unused import warning in headless builds



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8317)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 58a5369 into servo:master Nov 4, 2015
@mbrubeck mbrubeck deleted the glutin-warning branch May 11, 2016 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tetsuharuohzeki tetsuharuohzeki

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mbrubeck @tetsuharuohzeki @bors-servo @eefriedman @highfive