Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node change does not imply line breaking opportunity #874

Closed
sanxiyn opened this issue Sep 5, 2013 · 0 comments
Closed

Node change does not imply line breaking opportunity #874

sanxiyn opened this issue Sep 5, 2013 · 0 comments
Labels
A-layout/inline A-layout/text C-has-manual-testcase I-wrong An incorrect behaviour is observed.

Comments

@sanxiyn
Copy link
Contributor

sanxiyn commented Sep 5, 2013 

<div style="width: 100px;">ShouldNot<span>Break<span>This</div>

"ShouldNotBreakThis" is more than 100px and "ShouldNot" is less than 100px. There should be no line breaking, but currently Servo breaks the line before "Break".
@mbrubeck mbrubeck added I-wrong An incorrect behaviour is observed. C-has-manual-testcase A-layout/text labels May 24, 2016
@mbrubeck mbrubeck self-assigned this May 24, 2016
@mbrubeck mbrubeck mentioned this issue Sep 26, 2016
Merged
5 tasks
@splav splav mentioned this issue Oct 25, 2016
Closed
@mbrubeck mbrubeck removed their assignment Jan 3, 2018
@Manishearth Manishearth mentioned this issue Jan 4, 2018
Merged
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 12, 2018
@Manishearth
Share line breaking state across text runs
3743be1 
Fixes servo#874
bors-servo pushed a commit that referenced this issue Jan 12, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
5dc0a96 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 13, 2018
@Manishearth
Share line breaking state across text runs
1026c8a 
Fixes servo#874
bors-servo pushed a commit that referenced this issue Jan 13, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
ef5e71d 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 13, 2018
@Manishearth
Share line breaking state across text runs
0621eaf 
Fixes servo#874
bors-servo pushed a commit that referenced this issue Jan 13, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
1056a06 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 16, 2018
@Manishearth
Share line breaking state across text runs
7067ead 
Fixes servo#874
bors-servo pushed a commit that referenced this issue Jan 16, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
81afdec 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 17, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
b7eef5b 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 17, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
c0630f3 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 17, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
1370d2a 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
Manishearth added a commit to Manishearth/servo that referenced this issue Jan 23, 2018
@Manishearth
Share line breaking state across text runs
1b8ab81 
Fixes servo#874
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
36db4d1 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
3ab4dfc 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
e5e19f0 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
5013488 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
dc03803 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
4d6dfd7 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
e726fd7 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
021bd9f 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
b4c789d 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
b7526e8 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
6d0b6d9 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 23, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
8e5da09 
Detect adjoining text fragments with no whitespace between them and avoid linebreaking there

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 24, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
a294e9d 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 24, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
b58c6be 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 24, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
3233401 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 24, 2018
Auto merge of #19688 - Manishearth:linebreak, r=<try>
2e7eb94 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 25, 2018
Auto merge of #19688 - Manishearth:linebreak, r=mbrubeck
c63b94b 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 25, 2018
Auto merge of #19688 - Manishearth:linebreak, r=mbrubeck
e53663e 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 25, 2018
Auto merge of #19688 - Manishearth:linebreak, r=mbrubeck
9c13073 
Detect adjoining text fragments with no line break opportunity between them

First attempt at #874

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19688)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 25, 2018
@Manishearth
servo: Merge #19688 - Detect adjoining text fragments with no line br…
b3f6e35 
…eak opportunity between them (from Manishearth:linebreak); r=mbrubeck

First attempt at servo/servo#874

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 99d0f27c586a537f25a5285ed4447fc09e5de430
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
@marco-c
servo: Merge #19688 - Detect adjoining text fragments with no line br…
60d187c 
…eak opportunity between them (from Manishearth:linebreak); r=mbrubeck

First attempt at servo/servo#874

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511

UltraBlame original commit: 29192e93c875f06ce3915b01c761839df02f2264
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
@marco-c
servo: Merge #19688 - Detect adjoining text fragments with no line br…
c5189dc 
…eak opportunity between them (from Manishearth:linebreak); r=mbrubeck

First attempt at servo/servo#874

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511

UltraBlame original commit: 29192e93c875f06ce3915b01c761839df02f2264
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
@marco-c
servo: Merge #19688 - Detect adjoining text fragments with no line br…
c2ad68a 
…eak opportunity between them (from Manishearth:linebreak); r=mbrubeck

First attempt at servo/servo#874

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c1307307575637f5ad360413c6a8395579ab511

UltraBlame original commit: 29192e93c875f06ce3915b01c761839df02f2264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline A-layout/text C-has-manual-testcase I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbrubeck @sanxiyn