Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #9411 - Do not generate empty WebIDL 'Constant' modules #9430

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Fix issue #9411 - Do not generate empty WebIDL 'Constant' modules #9430

merged 1 commit into from
Jan 26, 2016

Conversation

rozbb
Copy link

@rozbb rozbb commented Jan 26, 2016

Fixes issue #9411

Review on Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 26, 2016
@nox
Copy link
Contributor

nox commented Jan 26, 2016

@bors-servo r+

Thanks for your contribution!

@bors-servo
Copy link
Contributor

📌 Commit 1f45eaf has been approved by nox

@nox nox self-assigned this Jan 26, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 26, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 1f45eaf with merge a19b143...

bors-servo pushed a commit that referenced this pull request Jan 26, 2016
Auto merge of #9430 - doomrobo:WebIDL-no-empty-const-modules, r=nox
a19b143 
Fix issue #9411 - Do not generate empty WebIDL 'Constant' modules

Fixes issue #9411
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9430)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 1f45eaf into servo:master Jan 26, 2016
@timvandermeij timvandermeij mentioned this pull request Jan 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rozbb @highfive @nox @bors-servo