Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when perspective property is zero. #9446

Merged
merged 1 commit into from Jan 29, 2016
Merged

Fix panic when perspective property is zero. #9446

merged 1 commit into from Jan 29, 2016

Conversation

glennw
Copy link
Member

@glennw glennw commented Jan 28, 2016

Review on Reviewable

@glennw
Copy link
Member Author

glennw commented Jan 28, 2016

r? @pcwalton

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 28, 2016
jdm
jdm reviewed Jan 28, 2016
View reviewed changes
tests/wpt/mozilla/tests/css/perspective_zero.html
@@ -0,0 +1,30 @@
<!DOCTYPE html>
<html>
<head>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing <link> to identify the reference file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - although it was definitely running that test locally without that line. Just out of curiosity, why do we need to list it both there and also (twice) in the manifest file?

@jdm
Copy link
Member

jdm commented Jan 28, 2016

The manifest file is generated automatically by extracting the metadata from the test files. Hand-editing MANIFEST.json is an anti-pattern; it should be updated via ./mach create-wpt or ./mach test-wpt --manifest-update.

@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 183c3f5 has been approved by pcwalton

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jan 28, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 183c3f5 with merge 1483a5d...

bors-servo pushed a commit that referenced this pull request Jan 28, 2016
Auto merge of #9446 - glennw:zero-perspective, r=pcwalton
1483a5d 
Fix panic when perspective property is zero.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9446)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 28, 2016
@glennw
Copy link
Member Author

glennw commented Jan 29, 2016

@bors-servo retry

(Seems infrastructure related - very large number of unrelated tests failed, which also has occurred to several other builds on this machine today).

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit 183c3f5 into servo:master Jan 29, 2016
@glennw glennw deleted the zero-perspective branch December 12, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glennw @jdm @pcwalton @bors-servo @highfive @gw3583