Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix step 14.2 of Range::ExtractContents #9799

Merged
merged 1 commit into from Feb 29, 2016
Merged

Fix step 14.2 of Range::ExtractContents #9799

merged 1 commit into from Feb 29, 2016

Conversation

nox
Copy link
Contributor

@nox nox commented Feb 28, 2016

We need the last inclusive ancestor of start node that is not an inclusive ancestor
of end node, not the first that is an inclusive ancestor of it.

Review on Reviewable

@nox
Fix step 14.2 of Range::ExtractContents
c0d7906 
We need the last inclusive ancestor of start node that is not an inclusive ancestor
of end node, not the first that is an inclusive ancestor of it.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 28, 2016
@emilio
Copy link
Member

emilio commented Feb 28, 2016

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit c0d7906 has been approved by ecoal95

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 28, 2016
@KiChjang
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

💡 This pull request was already approved, no need to approve it again.

@bors-servo
Copy link
Contributor

📌 Commit c0d7906 has been approved by KiChjang

@KiChjang KiChjang assigned KiChjang and unassigned Manishearth Feb 28, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit c0d7906 with merge dfdeabf...

bors-servo pushed a commit that referenced this pull request Feb 28, 2016
Auto merge of #9799 - nox:range-extractcontents, r=KiChjang
dfdeabf 
Fix step 14.2 of Range::ExtractContents

We need the last inclusive ancestor of start node that is not an inclusive ancestor
of end node, not the first that is an inclusive ancestor of it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9799)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Feb 29, 2016
@nox
Copy link
Contributor Author

nox commented Feb 29, 2016

@bors-servo retry #9772

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 29, 2016
@KiChjang
Copy link
Contributor 

Ran 4607 tests finished in 227.0 seconds.
  • 4606 ran as expected. 1374 tests skipped.
  • 1 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /websockets/cookies/005.html:
  └ PASS [expected FAIL] WebSockets: setting HttpOnly cookies in ws response, checking ws request

What is this? A new intermittent?

@frewsxcv
Copy link
Contributor

@bors-servo retry #9772

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 29, 2016
@nox
Copy link
Contributor Author

nox commented Feb 29, 2016

@bors-servo retry #9014

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@nox nox added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Feb 29, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit c0d7906 into servo:master Feb 29, 2016
@nox nox deleted the range-extractcontents branch February 29, 2016 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nox @emilio @bors-servo @KiChjang @frewsxcv @Manishearth @highfive