New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new command line flag --profile-dir [path] #10087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon. |
highfive
added
the
S-awaiting-review
There is new code that needs to be reviewed.
label
Mar 19, 2016
@bors-servo r=jdm (from #10084) |
📌 Commit cfe3af8 has been approved by |
highfive
added
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
and removed
S-awaiting-review
There is new code that needs to be reviewed.
labels
Mar 19, 2016
highfive
added
S-awaiting-review
There is new code that needs to be reviewed.
and removed
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
labels
Mar 20, 2016
@bors-servo r=jdm |
📌 Commit ddc96dc has been approved by |
highfive
added
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
and removed
S-awaiting-review
There is new code that needs to be reviewed.
labels
Mar 20, 2016
bors-servo
pushed a commit
that referenced
this pull request
Mar 20, 2016
add a new command line flag --profile-dir [path] add a new command line flag --profile-dir [path] that stores an optional directory path in the Opts struct in opts.rs, creating the directory if it does not exist. For the Implement HTTP authorization UI and persistent sessions student project. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10087) <!-- Reviewable:end -->
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-awaiting-merge
The PR is in the process of compiling and running tests on the automated CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new command line flag --profile-dir [path] that stores an optional directory path in the Opts struct in opts.rs, creating the directory if it does not exist.
For the Implement HTTP authorization UI and persistent sessions student project.
This change is