Upgrade mach to 0.6; stop vendoring mach. #10976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
cc @metajack |
When I originally rewrote Servo's mach bootstrapping (using virtualenv w/ requirements.txt in servo#7103), I didn't specify mach as a requirement because a new version hadn't been published in a while. Now that 0.6 is out, I asked the mach maintainers to publish a new version on PyPI, so now we can fetch it like the other Python dependencies. Fixes servo#10728.
frewsxcv
changed the title
|
@bors-servo r+ |
|
📌 Commit 7725e64 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
May 2, 2016
Upgrade mach to 0.6; stop vendoring mach. When I originally rewrote Servo's mach bootstrapping (using virtualenv w/ requirements.txt in #7103), I didn't specify mach as a requirement because a new version hadn't been published in a while. Now that 0.6 is out, I asked the mach maintainers to publish a new version on PyPI, so now we can fetch it like the other Python dependencies. Fixes #10728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10976) <!-- Reviewable:end -->
|
From what I can tell there is no mach changelog, so I made a diff of the changes in the upgrade: https://gist.github.com/frewsxcv/67c19788508225df88c558194f1c29e5 |
|
💔 Test failed - windows |
highfive
added
S-tests-failed
|
@bors-servo retry
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 3, 2016
Upgrade mach to 0.6; stop vendoring mach. When I originally rewrote Servo's mach bootstrapping (using virtualenv w/ requirements.txt in #7103), I didn't specify mach as a requirement because a new version hadn't been published in a while. Now that 0.6 is out, I asked the mach maintainers to publish a new version on PyPI, so now we can fetch it like the other Python dependencies. Fixes #10728. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10976) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows |
highfive
removed
the
S-awaiting-merge
frewsxcv
added a commit
to frewsxcv/servo
that referenced
this pull request
May 3, 2016
|
Great work @frewsxcv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally rewrote Servo's mach bootstrapping (using virtualenv
w/ requirements.txt in #7103), I didn't specify mach as a requirement
because a new version hadn't been published in a while. Now that 0.6
is out, I asked the mach maintainers to publish a new version on PyPI,
so now we can fetch it like the other Python dependencies.
Fixes #10728.
This change is