Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mach now shows stderr when a virtualenv or pip call fails (fixes #11055) #11067

Merged
merged 1 commit into from May 7, 2016
Merged

Mach now shows stderr when a virtualenv or pip call fails (fixes #11055) #11067

merged 1 commit into from May 7, 2016

Conversation

autrilla
Copy link
Contributor

@autrilla autrilla commented May 7, 2016 •
edited by larsbergstrom

This change is Reviewable

@highfive
Copy link

highfive commented May 7, 2016

Heads up! This PR modifies the following files:

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 7, 2016
@mbrubeck
Copy link
Contributor

mbrubeck commented May 7, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0fff10c has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 7, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 0fff10c with merge c226bf8...

bors-servo pushed a commit that referenced this pull request May 7, 2016
Auto merge of #11067 - autrilla:mach-errors, r=mbrubeck
c226bf8 
Mach now shows stderr when a virtualenv or pip call fails (fixes #11055)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 0fff10c into servo:master May 7, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 7, 2016
@bors-servo bors-servo mentioned this pull request May 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@autrilla @highfive @mbrubeck @bors-servo